8c/cgen64.c: rename local var cond→vcond to unshadow cond() function#130
Merged
Conversation
Local variable `cond` in cgen64() shadowed the file-local `cond(int op)` function (line 217). With TBOOL in place, `true` is now a keyword and the earlier true→cond rename in cgen.c made the shadowing problem visible at build time: line 2570 `cond(l->op)` was resolved to the int variable rather than the function, triggering "incompatible type: INT for op FUNC". https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the variable cond to vcond within the cgen64 function in sys/src/cmd/8c/cgen64.c. The renaming is consistently applied to the variable's declaration, its assignments within the comparison logic, and its usage in calls to the biggen function. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local variable
condin cgen64() shadowed the file-localcond(int op)function (line 217). With TBOOL in place,trueis now a keyword and the earlier true→cond rename in cgen.c made the shadowing problem visible at build time: line 2570cond(l->op)was resolved to the int variable rather than the function, triggering "incompatible type: INT for op FUNC".https://claude.ai/code/session_01WGAwvvTwDg2yknFkmZ3qzs